Merge lp:~renatofilho/webbrowser-app/fix-1359353 into lp:webbrowser-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 710
Merged at revision: 711
Proposed branch: lp:~renatofilho/webbrowser-app/fix-1359353
Merge into: lp:webbrowser-app
Diff against target: 92 lines (+59/-12)
1 file modified
src/app/webbrowser/NewTabView.qml (+59/-12)
To merge this branch: bzr merge lp:~renatofilho/webbrowser-app/fix-1359353
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+234115@code.launchpad.net

Commit message

Update the top sites visual.

To post a comment you must log in.
710. By Renato Araujo Oliveira Filho

Make backgroud image async.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:710
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1082/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4692/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3461
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/281
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/281
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/281/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/281
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4466/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5944
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5944/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13023
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2863
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3766
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3766/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1082/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/NewTabView.qml'
2--- src/app/webbrowser/NewTabView.qml 2014-07-29 22:31:49 +0000
3+++ src/app/webbrowser/NewTabView.qml 2014-09-10 13:53:17 +0000
4@@ -163,22 +163,17 @@
5
6 delegate: MouseArea {
7 width: units.gu(18)
8- height: units.gu(22)
9+ height: childrenRect.height
10
11 Column {
12- anchors.fill: parent
13+ anchors {
14+ left: parent.left
15+ right: parent.right
16+ }
17+ //height: childrenRect.height
18+
19 spacing: units.gu(1)
20
21- UbuntuShape {
22- width: parent.width
23- height: width
24-
25- Favicon {
26- anchors.centerIn: parent
27- source: model.icon
28- }
29- }
30-
31 Label {
32 width: parent.width
33 height: units.gu(2)
34@@ -189,6 +184,58 @@
35
36 text: model.title ? model.title : model.url
37 }
38+
39+ UbuntuShape {
40+ width: parent.width
41+ height: units.gu(10)
42+
43+ // we need that to clip the background image
44+ clip: true
45+
46+ Image {
47+ source: Qt.resolvedUrl("assets/tab-artwork.png")
48+ asynchronous: true
49+ width: parent.height
50+ height: width
51+ opacity: 0.6
52+ anchors {
53+ right: parent.right
54+ bottom: parent.bottom
55+ margins: units.gu(-3)
56+ }
57+ }
58+ Column {
59+ anchors {
60+ left: parent.left
61+ right: parent.right
62+ bottom: parent.bottom
63+ margins: units.gu(1)
64+ }
65+
66+ Favicon {
67+ source: model.icon
68+ }
69+
70+ Label {
71+ anchors {
72+ left: parent.left
73+ right: parent.right
74+ }
75+ elide: Text.ElideRight
76+ text: model.domain
77+ fontSize: "small"
78+ }
79+ Label {
80+ anchors {
81+ left: parent.left
82+ right: parent.right
83+ }
84+ elide: Text.ElideRight
85+ text: model.title
86+ fontSize: "small"
87+ }
88+ }
89+ }
90 }
91
92 onClicked: historyEntryClicked(model.url)

Subscribers

People subscribed via source and target branches

to status/vote changes: