Merge lp:~renatofilho/ubuntu-calendar-app/fix-unit-tests into lp:ubuntu-calendar-app

Proposed by Renato Araujo Oliveira Filho
Status: Superseded
Proposed branch: lp:~renatofilho/ubuntu-calendar-app/fix-unit-tests
Merge into: lp:ubuntu-calendar-app
Diff against target: 87 lines (+20/-17)
2 files modified
debian/control (+15/-15)
tests/unittests/tst_event_bubble.qml (+5/-2)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-calendar-app/fix-unit-tests
Reviewer Review Type Date Requested Status
Ubuntu Calendar Developers Pending
Review via email: mp+298446@code.launchpad.net

This proposal has been superseded by a proposal from 2016-06-27.

Commit message

[tst_new_event] Added missing build dep necessary for tests.
[tst_event_bubble] Make sure that initial event start date is always in the future.

To post a comment you must log in.
854. By Renato Araujo Oliveira Filho

More missing deps.

855. By Renato Araujo Oliveira Filho

Parent merged: ~osomon/ubuntu-calendar-app/deps-cleanup

856. By Renato Araujo Oliveira Filho

Reverted changes on debian/control.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-09-19 11:35:21 +0000
+++ debian/control 2016-06-27 16:52:35 +0000
@@ -5,10 +5,12 @@
5 debhelper (>= 9),5 debhelper (>= 9),
6 intltool,6 intltool,
7 python3,7 python3,
8 qml-module-qtorganizer,
9 qml-module-qtquick2,
10 qml-module-qttest,
11 qt5-default,
8 qtdeclarative5-dev-tools,12 qtdeclarative5-dev-tools,
9 qt5-default,13 qtdeclarative5-ubuntu-content1,
10 qtdeclarative5-qtquick2-plugin,
11 qtdeclarative5-test-plugin,
12Standards-Version: 3.9.414Standards-Version: 3.9.4
13Section: misc15Section: misc
14Homepage: https://launchpad.net/ubuntu-calendar-app16Homepage: https://launchpad.net/ubuntu-calendar-app
@@ -17,18 +19,17 @@
17Package: calendar-app19Package: calendar-app
18Architecture: all20Architecture: all
19Depends: ${misc:Depends},21Depends: ${misc:Depends},
22 libqt5contacts5,
23 libqt5organizer5,
20 qmlscene,24 qmlscene,
21 qtdeclarative5-quicklayouts-plugin,25 qml-module-qtcontacts,
26 qml-module-qtorganizer,
27 qml-module-qtquick-layouts,
28 qtcontact5-galera,
29 qtdeclarative5-ubuntu-syncmonitor0.1,
22 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,30 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
23 ${misc:Depends},
24 libqt5organizer5,
25 qtdeclarative5-qtorganizer-plugin,
26 qtorganizer5-eds,31 qtorganizer5-eds,
27 qtdeclarative5-ubuntu-syncmonitor0.1,
28 ubuntu-mobile-icons | suru-icon-theme,32 ubuntu-mobile-icons | suru-icon-theme,
29 libqt5contacts5,
30 qtdeclarative5-qtcontacts-plugin,
31 qtcontact5-galera,
32Description: Calendar application for Ubuntu devices33Description: Calendar application for Ubuntu devices
33 The Calendar application for Ubuntu devices lets you organise your life your34 The Calendar application for Ubuntu devices lets you organise your life your
34 way by month, week or daily diary.35 way by month, week or daily diary.
@@ -39,13 +40,12 @@
3940
40Package: calendar-app-autopilot41Package: calendar-app-autopilot
41Architecture: all42Architecture: all
42Depends: libautopilot-qt (>= 1.4),43Depends: address-book-service-dummy,
43 libqt5test5,44 address-book-service-testability,
45 autopilot-qt5,
44 calendar-app (= ${source:Version}),46 calendar-app (= ${source:Version}),
45 python3-dateutil,47 python3-dateutil,
46 ubuntu-ui-toolkit-autopilot,48 ubuntu-ui-toolkit-autopilot,
47 address-book-service-dummy,
48 address-book-service-testability
49Description: Autopilot tests for Ubuntu Calendar Application49Description: Autopilot tests for Ubuntu Calendar Application
50 This package contains autopilot tests for the Ubuntu Calendar application.50 This package contains autopilot tests for the Ubuntu Calendar application.
5151
5252
=== modified file 'tests/unittests/tst_event_bubble.qml'
--- tests/unittests/tst_event_bubble.qml 2016-03-31 19:19:33 +0000
+++ tests/unittests/tst_event_bubble.qml 2016-06-27 16:52:35 +0000
@@ -2,6 +2,8 @@
2import QtTest 1.02import QtTest 1.0
3import QtOrganizer 5.03import QtOrganizer 5.0
44
5import "../../dateExt.js" as DATE
6
5TestCase{7TestCase{
6 id: root8 id: root
7 name: "Event Bubble tests"9 name: "Event Bubble tests"
@@ -107,8 +109,9 @@
107 function init()109 function init()
108 {110 {
109 var collectionId = get_collection_id_by_name(root.model, root.collection.name)111 var collectionId = get_collection_id_by_name(root.model, root.collection.name)
110 var startDate = new Date(2016, 3, 28, 14, 0,0 )112 var startDate = new Date()
111 var endDate = new Date(2016, 3, 28, 15, 0,0 )113 startDate = startDate.addDays(1)
114 var endDate = startDate.addMinutes(60)
112 var eventData = {"collectionId": collectionId,115 var eventData = {"collectionId": collectionId,
113 "label": "Sample Test Event",116 "label": "Sample Test Event",
114 "allDay": false,117 "allDay": false,

Subscribers

People subscribed via source and target branches

to status/vote changes: