The gmock removal should have gone in a separate branch, IMO. This makes it harder to see the actual ~20 line patch
As to the actual patch... I'm a little worried that we carve out this special case, this patch looks like it cures the symptom rather than the underlying sync bug.
Still, as long as this is understood to be a temporary workaround for the inbox spam, and that this will be cleaned up when the sync bug is fixed, I'm OK with a temporary.
The gmock removal should have gone in a separate branch, IMO. This makes it harder to see the actual ~20 line patch
As to the actual patch... I'm a little worried that we carve out this special case, this patch looks like it cures the symptom rather than the underlying sync bug.
Still, as long as this is understood to be a temporary workaround for the inbox spam, and that this will be cleaned up when the sync bug is fixed, I'm OK with a temporary.