Code review comment for lp:~renatofilho/qtorganizer5-eds/fix-1424924

Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

The relevant EDS logic is in calendar/libecal/e-cal-recur.c; e.g. e_cal_recur_obtain_enddate()
which reasons that an event recurs forever if neither COUNT nor UNTIL are set.

So it makes sense for QOrganizerRecurrenceRule::NoLimit to be translated to
icalrecurrencetype.count==0 instead of
icalrecurrencetype.count==ICAL_RECURRENCE_ARRAY_MAX.

review: Approve

« Back to merge proposal