Merge lp:~renatofilho/messaging-app/register-as-destination into lp:messaging-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 575
Merged at revision: 578
Proposed branch: lp:~renatofilho/messaging-app/register-as-destination
Merge into: lp:messaging-app
Diff against target: 48 lines (+16/-6)
2 files modified
src/messaging-app-content.json (+7/-0)
src/qml/messaging-app.qml (+9/-6)
To merge this branch: bzr merge lp:~renatofilho/messaging-app/register-as-destination
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+300239@code.launchpad.net

Commit message

Register app as "destination" for "contacts", "pictures", "links", "text", "videos";

To post a comment you must log in.
575. By Renato Araujo Oliveira Filho

handle 'onImportRequested'.

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:574
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/56/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/986/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/986
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/888
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/888
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/888
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/885/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/885/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/885/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/885/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/885/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/885/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/885/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/885/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/885
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/885/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/56/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:575
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/57/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/987/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/987
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/889
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/889
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/889
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/886/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/886/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/886/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/886/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/886/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/886/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/886/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/886/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/886
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/886/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/57/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/messaging-app-content.json'
--- src/messaging-app-content.json 2016-01-27 19:58:52 +0000
+++ src/messaging-app-content.json 2016-07-15 19:28:37 +0000
@@ -1,4 +1,11 @@
1{1{
2 "destination": [
3 "contacts",
4 "pictures",
5 "links",
6 "text",
7 "videos"
8 ],
2 "share": [9 "share": [
3 "contacts",10 "contacts",
4 "pictures",11 "pictures",
512
=== modified file 'src/qml/messaging-app.qml'
--- src/qml/messaging-app.qml 2016-05-04 19:36:27 +0000
+++ src/qml/messaging-app.qml 2016-07-15 19:28:37 +0000
@@ -135,6 +135,13 @@
135 bottomEdge.commitWithProperties(properties)135 bottomEdge.commitWithProperties(properties)
136 }136 }
137137
138 function startImport(transfer) {
139 var properties = {}
140 emptyStack()
141 properties["sharedAttachmentsTransfer"] = transfer
142 mainView.showBottomEdgePage(properties)
143 }
144
138 Connections {145 Connections {
139 target: telepathyHelper146 target: telepathyHelper
140 // restore default bindings if any system settings changed147 // restore default bindings if any system settings changed
@@ -203,12 +210,8 @@
203210
204 Connections {211 Connections {
205 target: ContentHub212 target: ContentHub
206 onShareRequested: {213 onImportRequested: startImport(transfer)
207 var properties = {}214 onShareRequested: startImport(transfer)
208 emptyStack()
209 properties["sharedAttachmentsTransfer"] = transfer
210 mainView.showBottomEdgePage(properties)
211 }
212 }215 }
213216
214 signal applicationReady217 signal applicationReady

Subscribers

People subscribed via source and target branches