Code review comment for lp:~renatofilho/indicator-server/fix-1204661

Revision history for this message
Tony Espy (awe) wrote :

I'm going to approve because the fix definitely makes things better, however that said, I have a few comments that need to be addresses either in the UI component of the next-generation back-end which is supposed to land soon...

First, I did get the 'Mobile data' switch to come up in the wrong position once, however I looked away for a few seconds and when I looked back, it had toggled to 'On'. Weird.

Most of the time, when the network indicator is displayed, it's painted empty, the network list is added, then the toggle switches which are both off, and they both slide to on in tandem. I hope this lag in painting of the UI isn't by design, because it looks pretty bad. Also, every 20s or so, the menu re-paints ( I think this might be the update of the scanned networks ), and the toggle again do their dance from off to on.

Lastly, as there's no changelog entry, I'm not 'happroving' till the merge is updated.

review: Approve

« Back to merge proposal