Merge lp:~renatofilho/dialer-app/favorites-contacts into lp:dialer-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gustavo Pichorim Boiko | ||||
Approved revision: | 219 | ||||
Merged at revision: | 222 | ||||
Proposed branch: | lp:~renatofilho/dialer-app/favorites-contacts | ||||
Merge into: | lp:dialer-app | ||||
Diff against target: |
180 lines (+141/-2) 2 files modified
src/qml/ContactsPage/ContactsPage.qml (+136/-2) src/qml/dialer-app.qml (+5/-0) |
||||
To merge this branch: | bzr merge lp:~renatofilho/dialer-app/favorites-contacts | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Needs Fixing | |
Gustavo Pichorim Boiko (community) | Approve | ||
Review via email: mp+230543@code.launchpad.net |
Commit message
Add header section on ContactsPage to allow the user to switch between the "all" and "favorites" contacts.
Add an "Add new" button on contact list header.
To post a comment you must log in.
Are there any related MPs required for this MP to build/function as expected? NO
Is your branch in sync with latest trunk? YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES
Did you successfully run all tests found in your component's Test Plan on device or emulator? YES
If you changed the UI, was the change specified/approved by design? YES
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE