Code review comment for lp:~renatofilho/address-book-service/fix-1222994

Revision history for this message
Bill Filler (bfiller) wrote :

this doesn't fix the bug but does change the behavior. if I stop address-book-service the contacts view still shows the existing contacts which is different (the list used to be cleared). But then if I click on a contact to see it's details nothing happens. I would have expected an error or expected the service to be auto started by dbus activation when I'm requesting a detail.

Also, if service is stopped and you try to add a new contact the UI just spins an animation forever when you press the save button. It should either display an error or auto start the service via dbus activation

review: Needs Fixing

« Back to merge proposal