Merge lp:~renatofilho/address-book-service/fix-1193195 into lp:address-book-service

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 43
Merged at revision: 38
Proposed branch: lp:~renatofilho/address-book-service/fix-1193195
Merge into: lp:address-book-service
Prerequisite: lp:~renatofilho/address-book-service/missing-features
Diff against target: 63 lines (+3/-8)
2 files modified
common/vcard-parser.cpp (+2/-1)
src/qindividual.cpp (+1/-7)
To merge this branch: bzr merge lp:~renatofilho/address-book-service/fix-1193195
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+170996@code.launchpad.net

Commit message

Update server contact cache with the new contact info if update operation finish without error.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/vcard-parser.cpp'
--- common/vcard-parser.cpp 2013-06-23 22:38:25 +0000
+++ common/vcard-parser.cpp 2013-06-23 22:38:25 +0000
@@ -81,7 +81,8 @@
8181
82 virtual void contactProcessed(const QContact& contact, QVersitDocument* document)82 virtual void contactProcessed(const QContact& contact, QVersitDocument* document)
83 {83 {
84 //nothing84 Q_UNUSED(contact);
85 document->removeProperties("X-QTPROJECT-EXTENDED-DETAIL");
85 }86 }
86 };87 };
8788
8889
=== modified file 'src/qindividual.cpp'
--- src/qindividual.cpp 2013-06-23 22:38:25 +0000
+++ src/qindividual.cpp 2013-06-23 22:38:25 +0000
@@ -285,7 +285,6 @@
285 qWarning() << "NO PERSONA";285 qWarning() << "NO PERSONA";
286 return defaultPersona;286 return defaultPersona;
287 } else {287 } else {
288
289 GeeSet *personas = folks_individual_get_personas(individual);288 GeeSet *personas = folks_individual_get_personas(individual);
290 QStringList index = uri.split(".");289 QStringList index = uri.split(".");
291 Q_ASSERT(index.count() >= 1);290 Q_ASSERT(index.count() >= 1);
@@ -1410,11 +1409,11 @@
1410 }1409 }
14111410
1412 if (data->m_details.isEmpty()) {1411 if (data->m_details.isEmpty()) {
1412 data->m_self->m_contact = data->m_newContact;
1413 updateDetailsSendReply(data, 0);1413 updateDetailsSendReply(data, 0);
1414 return;1414 return;
1415 }1415 }
14161416
1417
1418 data->m_currentDetail = data->m_details.takeFirst();1417 data->m_currentDetail = data->m_details.takeFirst();
1419 switch(data->m_currentDetail.type()) {1418 switch(data->m_currentDetail.type()) {
1420 case QContactDetail::TypeAddress:1419 case QContactDetail::TypeAddress:
@@ -1501,7 +1500,6 @@
1501 g_object_ref(m_individual);1500 g_object_ref(m_individual);
1502 }1501 }
1503 // initialize qcontact1502 // initialize qcontact
1504 m_contact = QContact();
1505 updateContact();1503 updateContact();
1506 }1504 }
1507}1505}
@@ -1708,8 +1706,6 @@
1708{1706{
1709 static QMap<QString, int> map;1707 static QMap<QString, int> map;
17101708
1711 qDebug() << "PArse paramater:" << parameters;
1712
1713 // populate the map once1709 // populate the map once
1714 if (map.isEmpty()) {1710 if (map.isEmpty()) {
1715 map["home"] = QContactDetail::ContextHome;1711 map["home"] = QContactDetail::ContextHome;
@@ -1730,8 +1726,6 @@
1730 parameters.removeOne(param);1726 parameters.removeOne(param);
1731 }1727 }
17321728
1733 qDebug() << "PArseed paramater (DONE):" << parameters;
1734
1735 return values;1729 return values;
1736}1730}
17371731

Subscribers

People subscribed via source and target branches