Code review comment for lp:~renatofilho/address-book-service/enable-debug

Revision history for this message
Bill Filler (bfiller) wrote :

It basically works but we should fix the restart logic a bit. Currently it tries 10 times in a row to restart EDS, without any delay. This happens very quickly, probably too quickly.

Instead, you should sleep between each retry with a timer or something. Like try immediately after first failure, then sleep 2 seconds and retry, then sleep 3 seconds and retry, then sleep 4 seconds and retry, etc.. until you've tried 10 times.

review: Needs Fixing

« Back to merge proposal