Merge lp:~renatofilho/address-book-app/visuals-update into lp:address-book-app

[Renato Araujo Oliveira Filho]

Use a list of colors as avatar background color.
Use flat visual for avatar ubuntu shape.
Does not use 'lightAubergine' for labels.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:532
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1096/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/399/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6138/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6149/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1096/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/address-book-app/visuals-update]

533. By Renato Araujo Oliveira Filho on 2016-01-22

Update visuals for fast scrool.

534. By Renato Araujo Oliveira Filho on 2016-01-22

Update ContactAvatar test to work with the new component.

535. By Renato Araujo Oliveira Filho on 2016-01-22

Fixed warning messaging while creating ContactEditorPage.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:535
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1097/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/400
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6146
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4742
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6157
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6157/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26946

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1097/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/address-book-app/visuals-update]

536. By Renato Araujo Oliveira Filho on 2016-01-22

Use a hahs of contact full name to create a better result.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:536
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1098/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/401
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6159
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4752
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6170
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6170/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26966

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1098/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/address-book-app/visuals-update]

537. By Renato Araujo Oliveira Filho on 2016-02-04

Does not change the contact delegate label color to white while selected.

538. By Renato Araujo Oliveira Filho on 2016-02-04

Does not show orange rectangle on selected item in settings if no keyboard is present.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:538
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1103/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/406
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6333
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4863
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6344
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6344/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27318

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1103/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'src/imports/Settings/SettingsPage.qml'
--- src/imports/Settings/SettingsPage.qml	2016-01-05 14:04:19 +0000
+++ src/imports/Settings/SettingsPage.qml	2016-02-04 13:19:27 +0000
@@ -92,7 +92,7 @@
                 Rectangle {
                     color: UbuntuColors.orange
                     anchors.fill: parent
-                    visible:addGoogleAccountItem.activeFocus && pageStack.hasKeyboard
+                    visible: addGoogleAccountItem.activeFocus && pageStack.hasKeyboard
                     z: -1
                 }
             }
@@ -116,12 +116,12 @@
                 // FIXME: Using a private property here. This uses the old list item and the only way to change the text
                 // color is with this property.
                 // We should remove it when update the app to the new ListItem.
-                __foregroundColor: (activeFocus && (pageStack.columns > 1)) ? Theme.palette.normal.foregroundText :
+                __foregroundColor: (activeFocus && pageStack.hasKeyboard) ? Theme.palette.normal.foregroundText :
                                                                               Theme.palette.normal.foreground
                 Rectangle {
                     color: UbuntuColors.orange
                     anchors.fill: parent
-                    visible: importFromSimItem.activeFocus
+                    visible: importFromSimItem.activeFocus && pageStack.hasKeyboard
                     z: -1
                 }
             }
 
=== modified file 'src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml'
--- src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml	2016-01-07 12:21:49 +0000
+++ src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml	2016-02-04 13:19:27 +0000
@@ -118,7 +118,8 @@
         if (!item)
             return
 
-        var position = activeItem.mapToItem(editEditor, item.x, item.y);
+
+        var position = item.mapToItem(editEditor, item.x, item.y);
         // check if the item is already visible
         var bottomY = scrollArea.contentY + scrollArea.height
         var itemBottom = position.y + (item.height * 3) // extra margin
 
=== modified file 'src/imports/Ubuntu/AddressBook/ContactEditor/TextInputDetail.qml'
--- src/imports/Ubuntu/AddressBook/ContactEditor/TextInputDetail.qml	2016-01-06 18:54:07 +0000
+++ src/imports/Ubuntu/AddressBook/ContactEditor/TextInputDetail.qml	2016-02-04 13:19:27 +0000
@@ -91,7 +91,6 @@
             overlaySpacing: 0
             frameSpacing: 0
             background: Item {}
-            color: UbuntuColors.lightAubergine
         }
         onActiveFocusChanged: {
             if (activeFocus) {
 
=== modified file 'src/imports/Ubuntu/AddressBook/ContactView/BasicFieldView.qml'
--- src/imports/Ubuntu/AddressBook/ContactView/BasicFieldView.qml	2015-12-10 19:13:20 +0000
+++ src/imports/Ubuntu/AddressBook/ContactView/BasicFieldView.qml	2016-02-04 13:19:27 +0000
@@ -59,7 +59,6 @@
 
                 // style
                 fontSize: "medium"
-                color: UbuntuColors.lightAubergine
             }
         }
     }
 
=== modified file 'src/imports/Ubuntu/Contacts/CMakeLists.txt'
--- src/imports/Ubuntu/Contacts/CMakeLists.txt	2015-09-03 17:15:32 +0000
+++ src/imports/Ubuntu/Contacts/CMakeLists.txt	2016-02-04 13:19:27 +0000
@@ -31,6 +31,7 @@
     SIMList.qml
     SIMCardImportPage.qml
     SubtitledWithColors.qml
+    Triangle.qml
     VCardParser.qml
 )
 
 
=== modified file 'src/imports/Ubuntu/Contacts/ContactAvatar.qml'
--- src/imports/Ubuntu/Contacts/ContactAvatar.qml	2015-10-26 13:18:11 +0000
+++ src/imports/Ubuntu/Contacts/ContactAvatar.qml	2016-02-04 13:19:27 +0000
@@ -40,8 +40,9 @@
         initialsLabel.contactDisplayName = Qt.binding(function() { return ContactsJS.formatToDisplayWithDetails(contactElement, ContactDetail.Name, [Name.FirstName, Name.LastName], fallbackDisplayName) })
     }
 
+    aspect: UbuntuShape.Flat
     radius: "medium"
-    backgroundColor: Theme.palette.normal.overlay
+    backgroundColor: ContactsJS.contactColor(displayName)
 
     Label {
         id: initialsLabel
@@ -51,8 +52,8 @@
 
         anchors.centerIn: parent
         text: Contacts.contactInitialsFromString(contactDisplayName)
-        color: UbuntuColors.lightAubergine
-        visible: (img.status != Image.Ready)
+        color: "white"
+        visible: (img.status != Image.Ready) && !fallbackIcon.visible
         fontSize: "large"
     }
 
@@ -65,13 +66,24 @@
 
         property string avatarUrl: ContactsJS.getAvatar(contactElement, fallbackAvatarUrl)
 
-        anchors.centerIn: visible ? avatar : undefined
         asynchronous: true
-        source: avatar.showAvatarPicture ? avatar.avatarUrl : ""
-        height: visible ? units.gu(3) : avatar.height
+        source: avatar.showAvatarPicture && (avatar.avatarUrl.indexOf("image://theme/") === -1)  ? avatar.avatarUrl : ""
+        height: avatar.height
         width: height
-        visible: avatar.avatarUrl.indexOf("image://theme/") === 0
+        visible: false
         sourceSize.width: avatar.width
         sourceSize.height: avatar.height
     }
+
+    Icon {
+        id: fallbackIcon
+        objectName: "fallbackIcon"
+
+        source: visible ? img.avatarUrl : ""
+        visible: avatar.showAvatarPicture && (avatar.avatarUrl.indexOf("image://theme/") === 0)
+        color: "white"
+        anchors.centerIn: avatar
+        height: units.gu(3)
+        width: height
+    }
 }
 
=== modified file 'src/imports/Ubuntu/Contacts/ContactDelegate.qml'
--- src/imports/Ubuntu/Contacts/ContactDelegate.qml	2015-12-10 19:13:20 +0000
+++ src/imports/Ubuntu/Contacts/ContactDelegate.qml	2016-02-04 13:19:27 +0000
@@ -76,7 +76,7 @@
                 verticalCenter: parent.verticalCenter
                 right: parent.right
             }
-            color: UbuntuColors.lightAubergine
+            color: UbuntuColors.darkGrey
             text: root.displayLabel != "" ? root.displayLabel : i18n.dtr("address-book-app", "No name")
             elide: Text.ElideRight
         }
 
=== modified file 'src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml'
--- src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml	2015-10-26 13:18:11 +0000
+++ src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml	2016-02-04 13:19:27 +0000
@@ -80,7 +80,6 @@
                 }
 
                 text: i18n.dtr("address-book-app", "Add number...")
-                color: UbuntuColors.lightAubergine
             }
             visible: phoneNumberEntries.count == 0
             MouseArea {
@@ -104,7 +103,6 @@
                 text: modelData.number
                 subText: phoneTypeModel.get(phoneTypeModel.getTypeIndex(modelData)).label
                 onClicked: root.detailClicked(modelData, "call")
-                textColor: UbuntuColors.lightAubergine
 
                 MouseArea {
                     anchors {
 
=== modified file 'src/imports/Ubuntu/Contacts/ContactListButtonDelegate.qml'
--- src/imports/Ubuntu/Contacts/ContactListButtonDelegate.qml	2015-10-26 13:18:11 +0000
+++ src/imports/Ubuntu/Contacts/ContactListButtonDelegate.qml	2016-02-04 13:19:27 +0000
@@ -73,7 +73,6 @@
            right: parent.right
            rightMargin: units.gu(2)
        }
-       color: UbuntuColors.lightAubergine
        elide: Text.ElideRight
        visible: root.showContents
    }
 
=== modified file 'src/imports/Ubuntu/Contacts/Contacts.js'
--- src/imports/Ubuntu/Contacts/Contacts.js	2015-06-01 18:26:26 +0000
+++ src/imports/Ubuntu/Contacts/Contacts.js	2016-02-04 13:19:27 +0000
@@ -1,5 +1,6 @@
 
 var phoneTypeModel = null
+var contactColors = ["#DC3023", "#FF8936", "#FFB95A", "#8DB255", "#749F8D", "#48929B", "#A87CA0"]
 
 // Format contact name to be displayed
 function formatToDisplayWithDetails(contact, contactDetail, detailFields, defaultTitle)
@@ -145,3 +146,9 @@
 {
     return (contact && (contact.contactId === "qtcontacts:::"))
 }
+
+function contactColor(name)
+{
+    var hash = Contacts.qHash(name)
+    return contactColors[(hash % contactColors.length)]
+}
 
=== modified file 'src/imports/Ubuntu/Contacts/FastScroll.qml'
--- src/imports/Ubuntu/Contacts/FastScroll.qml	2015-12-10 19:08:19 +0000
+++ src/imports/Ubuntu/Contacts/FastScroll.qml	2016-02-04 13:19:27 +0000
@@ -72,15 +72,16 @@
     }
 
 
-    Rectangle {
+    UbuntuShape {
         id: magnified
 
+        aspect: UbuntuShape.Flat
         color: Theme.palette.normal.foreground
-        radius: height * 0.3
-        height: pinSize * 2
-        width: height
+        radius: "medium"
+        height: units.gu(6)
+        width: units.gu(8)
         opacity: internal.fastScrolling && root.enabled ? 1.0 : 0.0
-        x: -cursor.width - units.gu(3)
+        x: -magnified.width
         y: {
             if (internal.currentItem) {
                 var itemCenterY = rail.y + internal.currentItem.y + (internal.currentItem.height / 2)
@@ -90,6 +91,20 @@
             }
         }
 
+        Triangle {
+            id: arrow
+
+            color: magnified.color
+            fill: true
+            height: units.gu(1.5)
+            width: units.gu(0.5)
+            anchors {
+                verticalCenter: parent.verticalCenter
+                right: parent.right
+                rightMargin: -width
+            }
+        }
+
         Label {
             color: Theme.palette.normal.foregroundText
             anchors.fill: parent
 
=== modified file 'src/imports/Ubuntu/Contacts/ListItemWithActions.qml'
--- src/imports/Ubuntu/Contacts/ListItemWithActions.qml	2016-01-06 15:09:18 +0000
+++ src/imports/Ubuntu/Contacts/ListItemWithActions.qml	2016-02-04 13:19:27 +0000
@@ -246,7 +246,7 @@
                        width: units.gu(3)
                        height: units.gu(3)
                        name: modelData.iconName
-                       color: root.activeAction === modelData ? UbuntuColors.lightAubergine : UbuntuColors.lightGrey
+                       color: root.activeAction === modelData ? UbuntuColors.orange : UbuntuColors.lightGrey
                    }
               }
            }
 
=== added file 'src/imports/Ubuntu/Contacts/Triangle.qml'
--- src/imports/Ubuntu/Contacts/Triangle.qml	1970-01-01 00:00:00 +0000
+++ src/imports/Ubuntu/Contacts/Triangle.qml	2016-02-04 13:19:27 +0000
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.4
+
+Canvas {
+    id: triangle
+    antialiasing: true
+
+    property color color: "#ffffff"
+    property int lineWidth: 3
+    property bool fill: false
+
+    onLineWidthChanged:requestPaint();
+    onFillChanged:requestPaint();
+
+    onPaint: {
+        var ctx = getContext("2d");
+        ctx.save();
+        ctx.clearRect(0,0,triangle.width, triangle.height);
+        ctx.strokeStyle = triangle.color;
+        ctx.lineWidth = triangle.lineWidth
+        ctx.fillStyle = triangle.color
+        ctx.globalAlpha = 1.0
+        ctx.lineJoin = "round";
+        ctx.beginPath();
+
+        ctx.translate(0,  0);
+        ctx.lineTo(0, triangle.height);
+        ctx.lineTo(triangle.width,  0.5 * triangle.height);
+        ctx.lineTo(0,  0);
+
+        if (triangle.fill)
+          ctx.fill();
+        if (triangle.stroke)
+          ctx.stroke();
+        ctx.restore();
+    }
+}
 
=== modified file 'src/imports/Ubuntu/Contacts/contacts.cpp'
--- src/imports/Ubuntu/Contacts/contacts.cpp	2015-10-28 19:42:30 +0000
+++ src/imports/Ubuntu/Contacts/contacts.cpp	2016-02-04 13:19:27 +0000
@@ -109,6 +109,11 @@
     return QFile::exists(updaterLockFile());
 }
 
+uint UbuntuContacts::qHash(const QString &str)
+{
+    return ::qHash(str);
+}
+
 QString UbuntuContacts::updaterLockFile()
 {
     return QString("%1/%2").arg(QDir::tempPath()).arg("/address-book-updater.lock");
 
=== modified file 'src/imports/Ubuntu/Contacts/contacts.h'
--- src/imports/Ubuntu/Contacts/contacts.h	2015-10-28 19:42:30 +0000
+++ src/imports/Ubuntu/Contacts/contacts.h	2016-02-04 13:19:27 +0000
@@ -40,6 +40,7 @@
     Q_INVOKABLE bool containsLetters(const QString &value);
     Q_INVOKABLE bool removeFile(const QUrl &file);
     Q_INVOKABLE bool updateIsRunning() const;
+    Q_INVOKABLE uint qHash(const QString &str);
 
 Q_SIGNALS:
     void imageCopyDone(const QString &id, const QString &fileName);
 
=== modified file 'tests/qml/tst_ContactAvatar.qml'
--- tests/qml/tst_ContactAvatar.qml	2015-10-26 13:18:11 +0000
+++ tests/qml/tst_ContactAvatar.qml	2016-02-04 13:19:27 +0000
@@ -151,14 +151,20 @@
             waitForRendering(avatarComponent);
             var avatarInitials = findChild(avatarComponent, "avatarInitials")
             var avatarImage = findChild(avatarComponent, "avatarImage")
+            var avatarFallback = findChild(avatarComponent, "fallbackIcon")
 
             avatarComponent.showAvatarPicture = true
             tryCompare(avatarInitials, "visible", false)
-            tryCompare(avatarImage, "source", avatarComponent.fallbackAvatarUrl)
+            tryCompare(avatarImage, "source", "")
+            tryCompare(avatarFallback, "visible", true)
+            tryCompare(avatarFallback, "source", avatarComponent.fallbackAvatarUrl)
 
             avatarComponent.showAvatarPicture = false
             tryCompare(avatarImage, "source", "")
             tryCompare(avatarImage, "status", Image.Null)
+            tryCompare(avatarFallback, "visible", false)
+            tryCompare(avatarFallback, "source", "")
+
             tryCompare(avatarInitials, "visible", true)
         }
     }