Code review comment for lp:~renatofilho/address-book-app/search

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

I found a couple of issues:

1) there is no way to see the last items in the list view when the osk is open. The list view should attach to the osk top.

2) the search field should have word prediction disabled, otherwise it won't trigger the query until the entered text is committed (space or tap in a suggested word). Something like this should be enough: inputMethodHints: Qt.ImhNoPredictiveText

3) on the device with a big contact list (+600 contacts) the app crashes when you change the search term too fast, it seems to me like the search filter is being changed any time you change the search term right away. That means if the user types the search term too fast, the app will crash.

4) I know that the contact list collapse is going away, but if you collapse the list and switch to favorites while the list is still collapsing, the app crashes too.

review: Needs Fixing

« Back to merge proposal