address-book-app

Code review comment for lp:~renatofilho/address-book-app/new-bottom-edge

  1. new-bottom-edge
  2. Merge into trunk
Revision history for this message
Bill Filler (bfiller) wrote :

Silo 55:
tesing on krillin

- try to search, type in search string, open resultant contact, click back, now you are stuck on search page with back button disabled
See this in log
file:///usr/share/address-book-app/imports/ABContactListPage.qml:615: TypeError: Cannot read property 'status' of null
file:///usr/share/address-book-app/imports/ABContactListPage.qml:441: TypeError: Cannot read property 'status' of null

- opening a contact, sometimes get a page with no back button, it's happend 3 or 4 times but can't reproduce reliably

- the order of the icons changed on the toolbar, settings and search positions are swapped

- Very often bottom edge swipe fails and it does not get properly activated (doesn't get displayed), when this happens I see multiple failure messages:
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search

- There is a very big delay in the animation when swiping up from bottom, the page does not follow my finger as it used to. We had this problem in the past and needed to have the page created up front as it takes too long to create it dynamically. This shouldn't be done at start up but after the app is displayed then it should be created and cached.

- Open bottom edge, then close it, get these errors in log
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search

- pressing edit on a contact is slow again

- I see multiple of these errors everytime trying to edit a contact
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.0/Icon.qml:37:5: QML QQuickImage: Failed to get image from provider: image://theme/clear-search

review: Needs Fixing

« Back to merge proposal