Merge lp:~renatofilho/address-book-app/fix-scroll-to-contact into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 582
Merged at revision: 584
Proposed branch: lp:~renatofilho/address-book-app/fix-scroll-to-contact
Merge into: lp:address-book-app
Diff against target: 34 lines (+4/-2)
2 files modified
src/imports/ABContactListPage.qml (+2/-1)
src/imports/ABMultiColumnEmptyState.qml (+2/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-scroll-to-contact
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+294282@code.launchpad.net

Commit message

Make sure that the contact list scroll to correct contact on dual panel mode.

Use contact list model for bottom edge element in empty state page. This will make sure that the model used is the same model used in contact list, and the model that we are connected to new contact signal.

To post a comment you must log in.
Revision history for this message
Arthur Mello (artmello) :
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/imports/ABContactListPage.qml'
--- src/imports/ABContactListPage.qml 2016-03-21 12:33:51 +0000
+++ src/imports/ABContactListPage.qml 2016-05-10 18:02:41 +0000
@@ -126,7 +126,8 @@
126 emptyPage = pageStack.addFileToNextColumnSync(pageStack.primaryPage,126 emptyPage = pageStack.addFileToNextColumnSync(pageStack.primaryPage,
127 Qt.resolvedUrl("ABMultiColumnEmptyState.qml"),127 Qt.resolvedUrl("ABMultiColumnEmptyState.qml"),
128 { 'headerTitle': "",128 { 'headerTitle': "",
129 'pageStack': mainPage.pageStack })129 'pageStack': mainPage.pageStack,
130 'model': mainPage.contactModel })
130 emptyPage.Component.onDestruction.connect(function() {131 emptyPage.Component.onDestruction.connect(function() {
131 mainPage.emptyPage = null132 mainPage.emptyPage = null
132 })133 })
133134
=== modified file 'src/imports/ABMultiColumnEmptyState.qml'
--- src/imports/ABMultiColumnEmptyState.qml 2016-02-13 02:36:26 +0000
+++ src/imports/ABMultiColumnEmptyState.qml 2016-05-10 18:02:41 +0000
@@ -24,6 +24,7 @@
24 property string headerTitle: i18n.tr("No contacts")24 property string headerTitle: i18n.tr("No contacts")
2525
26 property bool openBottomEdgeWhenReady: false26 property bool openBottomEdgeWhenReady: false
27 property var model: null
2728
28 header: PageHeader {29 header: PageHeader {
29 title: root.headerTitle30 title: root.headerTitle
@@ -71,7 +72,7 @@
71 hintVisible: false72 hintVisible: false
72 parent: root73 parent: root
73 height: root.height74 height: root.height
74 modelToEdit: root.pageStack.contactListPage.contactModel75 modelToEdit: root.model
75 hint.flickable: root.flickable76 hint.flickable: root.flickable
76 pageStack: root.pageStack77 pageStack: root.pageStack
77 onCommitCompleted: { root.openBottomEdgeWhenReady = false }78 onCommitCompleted: { root.openBottomEdgeWhenReady = false }

Subscribers

People subscribed via source and target branches