Merge lp:~renatofilho/address-book-app/fix-scroll-to-contact into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 582
Merged at revision: 584
Proposed branch: lp:~renatofilho/address-book-app/fix-scroll-to-contact
Merge into: lp:address-book-app
Diff against target: 34 lines (+4/-2)
2 files modified
src/imports/ABContactListPage.qml (+2/-1)
src/imports/ABMultiColumnEmptyState.qml (+2/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-scroll-to-contact
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Ubuntu Phablet Team Pending
Review via email: mp+294282@code.launchpad.net

Commit message

Make sure that the contact list scroll to correct contact on dual panel mode.

Use contact list model for bottom edge element in empty state page. This will make sure that the model used is the same model used in contact list, and the model that we are connected to new contact signal.

To post a comment you must log in.
Revision history for this message
Arthur Mello (artmello) :
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ABContactListPage.qml'
2--- src/imports/ABContactListPage.qml 2016-03-21 12:33:51 +0000
3+++ src/imports/ABContactListPage.qml 2016-05-10 18:02:41 +0000
4@@ -126,7 +126,8 @@
5 emptyPage = pageStack.addFileToNextColumnSync(pageStack.primaryPage,
6 Qt.resolvedUrl("ABMultiColumnEmptyState.qml"),
7 { 'headerTitle': "",
8- 'pageStack': mainPage.pageStack })
9+ 'pageStack': mainPage.pageStack,
10+ 'model': mainPage.contactModel })
11 emptyPage.Component.onDestruction.connect(function() {
12 mainPage.emptyPage = null
13 })
14
15=== modified file 'src/imports/ABMultiColumnEmptyState.qml'
16--- src/imports/ABMultiColumnEmptyState.qml 2016-02-13 02:36:26 +0000
17+++ src/imports/ABMultiColumnEmptyState.qml 2016-05-10 18:02:41 +0000
18@@ -24,6 +24,7 @@
19 property string headerTitle: i18n.tr("No contacts")
20
21 property bool openBottomEdgeWhenReady: false
22+ property var model: null
23
24 header: PageHeader {
25 title: root.headerTitle
26@@ -71,7 +72,7 @@
27 hintVisible: false
28 parent: root
29 height: root.height
30- modelToEdit: root.pageStack.contactListPage.contactModel
31+ modelToEdit: root.model
32 hint.flickable: root.flickable
33 pageStack: root.pageStack
34 onCommitCompleted: { root.openBottomEdgeWhenReady = false }

Subscribers

People subscribed via source and target branches