Code review comment for lp:~renatofilho/address-book-app/fix-bottom-edge-animations

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

In your rev 292, you added a final animation when the bottom edge page gets fully visible (based on designer trasition doc). Can you provide a link to that document and also enable sharing with me please since that animation is causing the listview in the bottom edge page to jump up 4 grid units and then come down which is unpleasant. I want to show the document to the clock app designer to get his input.

279 + SmoothedAnimation {
280 + target: edgeLoader
281 + property: "anchors.topMargin"
282 + to: - units.gu(4)
283 + duration: UbuntuAnimation.FastDuration
284 + easing.type: Easing.Linear
285 + }
286 + SmoothedAnimation {
287 + target: edgeLoader
288 + property: "anchors.topMargin"
289 + to: 0
290 + duration: UbuntuAnimation.FastDuration
291 + easing: UbuntuAnimation.StandardEasing
292 }

If you look at the bug report and also design doc at https://docs.google.com/presentation/d/1YuB3SW5UKI5t9ox4Gc9snsOnFAr1j0PTFjbtK-eLO8w/edit#slide=id.g386935507_0225, it says that the bottom edge hint must be visible on app startup and only disappear when the user starts interacting with the screen. In my testing, the bottom edge hint appears hidden on app start up. Only when I press it once, does it show up and stays shown.

Also the bottom edge should reveal itself automatically after 5 seconds when the user has stopped interacting with the screen. I don't see any timer which does this. Also in my testing, this behavior was not observed.

review: Needs Fixing

« Back to merge proposal