Merge lp:~renatofilho/address-book-app/fix-1467271 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 582
Merged at revision: 585
Proposed branch: lp:~renatofilho/address-book-app/fix-1467271
Merge into: lp:address-book-app
Diff against target: 25 lines (+6/-2)
1 file modified
src/imports/Ubuntu/Contacts/ContactListModel.qml (+6/-2)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1467271
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+294299@code.launchpad.net

Commit message

Trim search term before query.

To post a comment you must log in.
582. By Renato Araujo Oliveira Filho

Trim search term before query.

Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/imports/Ubuntu/Contacts/ContactListModel.qml'
--- src/imports/Ubuntu/Contacts/ContactListModel.qml 2015-10-26 13:18:11 +0000
+++ src/imports/Ubuntu/Contacts/ContactListModel.qml 2016-05-10 20:49:48 +0000
@@ -140,7 +140,7 @@
140 }140 }
141141
142 root.changeFilter(root.externalFilter)142 root.changeFilter(root.externalFilter)
143 contactTermFilter.value = root.filterTerm143 contactTermFilter.value = root.filterTerm.trim()
144144
145 // manually update if autoUpdate is disabled145 // manually update if autoUpdate is disabled
146 if (!root.autoUpdate) {146 if (!root.autoUpdate) {
@@ -149,7 +149,11 @@
149 }149 }
150 }150 }
151151
152 onFilterTermChanged: contactSearchTimeout.restart()152 onFilterTermChanged: {
153 var newFilterTerm = root.filterTerm.trim()
154 if (contactTermFilter.value != newFilterTerm)
155 contactSearchTimeout.restart()
156 }
153157
154 onErrorChanged: {158 onErrorChanged: {
155 if (error) {159 if (error) {

Subscribers

People subscribed via source and target branches