Merge lp:~renatofilho/address-book-app/fix-1204564 into lp:address-book-app

[Renato Araujo Oliveira Filho]

Does not save a empty contact.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/106/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-amd64-ci/106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/106
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/106/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-i386-ci/106

Click here to trigger a rebuild:
http://s-jenkins:8080/job/address-book-app-ci/106/rebuild

review: Approve (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

This patch works fine. If you try to save an empty contact, it will indeed be ignored.
I am just wondering if we could disable the save button in case all the fields are blank instead of accepting the action and do nothing. The user would be forced to cancel, and the result of such action would be more clear.

review: Needs Information

[Tiago Salem Herrmann (tiagosh)]

This behavior needs to be discussed with designers.
Let's approve this for now and change it later if necessary.

review: Approve

=== modified file 'src/imports/ContactEdit/ContactDetailAvatarEditor.qml'
--- src/imports/ContactEdit/ContactDetailAvatarEditor.qml	2013-07-25 20:58:38 +0000
+++ src/imports/ContactEdit/ContactDetailAvatarEditor.qml	2013-08-07 18:59:25 +0000
@@ -23,6 +23,11 @@
 ContactDetailBase {
     id: root
 
+    function save() {
+        //TODO: not implemented
+        return false
+    }
+
     detail: contact ? contact.avatar : null
     implicitHeight: units.gu(17)
 
 
=== modified file 'src/imports/ContactEdit/ContactEditor.qml'
--- src/imports/ContactEdit/ContactEditor.qml	2013-08-02 17:40:44 +0000
+++ src/imports/ContactEdit/ContactEditor.qml	2013-08-07 18:59:25 +0000
@@ -38,6 +38,22 @@
             }
         }
 
+        // new contact and there is only two details (name, avatar)
+        // name and avatar, are not removable details, because of that the contact will have at least 2 details
+        if ((contact.contactId === "qtcontacts:::") &&
+            (contact.contactDetails.length === 2)) {
+
+            // if name is empty this means that the contact is empty
+            var nameDetail = contact.detail(ContactDetail.Name)
+            if (nameDetail &&
+                (nameDetail.firstName && nameDetail.firstName != "") ||
+                (nameDetail.lastName && nameDetail.lastName != "")) {
+                // save contact
+            } else {
+                changed  = false
+            }
+        }
+
         if (changed) {
             model.saveContact(contact)
         } else {