Merge lp:~renatofilho/address-book-app/fix-1199122 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 12
Merged at revision: 12
Proposed branch: lp:~renatofilho/address-book-app/fix-1199122
Merge into: lp:address-book-app
Prerequisite: lp:~renatofilho/address-book-app/fix-1200397
Diff against target: 72 lines (+16/-4)
3 files modified
src/artwork/CMakeLists.txt (+1/-0)
src/imports/ContactEdit/ContactEditor.qml (+4/-3)
src/imports/main.qml (+11/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1199122
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+174428@code.launchpad.net

Commit message

Make sure that the toolbar is always visible when in edit mode.

To post a comment you must log in.
10. By Renato Araujo Oliveira Filho

Make sure that the toolbar is always visible when in edit mode.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
11. By Renato Araujo Oliveira Filho

Added save icon.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
12. By Renato Araujo Oliveira Filho

Make sure that the toolbar is visible when it is locked and the input method appears

Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/artwork/CMakeLists.txt'
--- src/artwork/CMakeLists.txt 2013-07-05 16:56:13 +0000
+++ src/artwork/CMakeLists.txt 2013-07-12 20:37:29 +0000
@@ -25,6 +25,7 @@
25 protocol-qq.png25 protocol-qq.png
26 protocol-skype.png26 protocol-skype.png
27 protocol-yahoo.png27 protocol-yahoo.png
28 save.png
28 settings.png29 settings.png
29)30)
3031
3132
=== added file 'src/artwork/save.png'
32Binary files src/artwork/save.png 1970-01-01 00:00:00 +0000 and src/artwork/save.png 2013-07-12 20:37:29 +0000 differ33Binary files src/artwork/save.png 1970-01-01 00:00:00 +0000 and src/artwork/save.png 2013-07-12 20:37:29 +0000 differ
=== modified file 'src/imports/ContactEdit/ContactEditor.qml'
--- src/imports/ContactEdit/ContactEditor.qml 2013-07-12 20:37:29 +0000
+++ src/imports/ContactEdit/ContactEditor.qml 2013-07-12 20:37:29 +0000
@@ -151,16 +151,17 @@
151 }151 }
152152
153 tools: ToolbarItems {153 tools: ToolbarItems {
154 locked: true
155 opened: true
154 ToolbarButton {156 ToolbarButton {
155 action: Action {157 action: Action {
156 text: i18n.tr("Save")158 text: i18n.tr("Done")
157 iconSource: "artwork:/edit.png"159 iconSource: "artwork:/save.png"
158 onTriggered: {160 onTriggered: {
159 // wait for contact to be saved or cause a error161 // wait for contact to be saved or cause a error
160 contactSaveLock.saving = true162 contactSaveLock.saving = true
161 contactEditor.save()163 contactEditor.save()
162 }164 }
163
164 }165 }
165 }166 }
166 }167 }
167168
=== modified file 'src/imports/main.qml'
--- src/imports/main.qml 2013-07-12 20:37:29 +0000
+++ src/imports/main.qml 2013-07-12 20:37:29 +0000
@@ -29,18 +29,28 @@
2929
30 anchors {30 anchors {
31 fill: parent31 fill: parent
32 bottomMargin: Qt.inputMethod.visible ? (Qt.inputMethod.keyboardRectangle.height - mainView.anchors.bottomMargin) + units.gu(2) : 0
33 Behavior on bottomMargin {32 Behavior on bottomMargin {
34 NumberAnimation {33 NumberAnimation {
35 duration: 17534 duration: 175
36 easing.type: Easing.OutQuad35 easing.type: Easing.OutQuad
37 }36 }
38 }37 }
38
39 // make the page full visible if the inputMethod appears
40 bottomMargin: Qt.inputMethod.visible ? toolbar.height + Qt.inputMethod.keyboardRectangle.height + units.gu(2) : 0
39 //TODO: waiting for final design to correct implementation41 //TODO: waiting for final design to correct implementation
40 onBottomMarginChanged: console.debug("TODO: implement scroll to correct position")42 onBottomMarginChanged: console.debug("TODO: implement scroll to correct position")
41 }43 }
42 }44 }
4345
46 // Make the toolbar visible if it is locked and the inputMethod appears
47 Binding {
48 target: toolbar
49 property: "anchors.bottomMargin"
50 value: Qt.inputMethod.visible && toolbar.locked ? Qt.inputMethod.keyboardRectangle.height : 0
51 when: toolbar
52 }
53
44 Component.onCompleted: {54 Component.onCompleted: {
45 mainStack.push(Qt.createComponent("ContactList/ContactList.qml"))55 mainStack.push(Qt.createComponent("ContactList/ContactList.qml"))
46 }56 }

Subscribers

People subscribed via source and target branches