Code review comment for lp:~renatofilho/address-book-app/contact-share

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Couple of issue, when sharing I'm now getting:

file:///usr/share/address-book-app/imports/ContactShare/ContactSharePage.qml:51: ReferenceError: contactExporter is not defined

And when either exporting to another application or sharing, the exported .vcf file contains *all* contacts, not just the selected/shared ones.

Also as a minor thing the import of Ubuntu.Components.Popups 0.1 in ContactView.qml doesn't seem to be needed any more

review: Needs Fixing

« Back to merge proposal