Merge lp:~renatofilho/address-book-app/code-style-fix into lp:~fboucault/address-book-app/converged_bottom_edge

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 509
Proposed branch: lp:~renatofilho/address-book-app/code-style-fix
Merge into: lp:~fboucault/address-book-app/converged_bottom_edge
Diff against target: 65 lines (+14/-13)
1 file modified
src/imports/ABContactListPage.qml (+14/-13)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/code-style-fix
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+275530@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/imports/ABContactListPage.qml'
--- src/imports/ABContactListPage.qml 2015-10-23 11:05:56 +0000
+++ src/imports/ABContactListPage.qml 2015-10-23 12:41:25 +0000
@@ -152,6 +152,12 @@
152 editorPage.contactSaved.connect(onNewContactSaved);152 editorPage.contactSaved.connect(onNewContactSaved);
153 }153 }
154154
155 function onNewContactSaved(contact) {
156 if (pageStack.columns > 1) {
157 showContact(contact);
158 }
159 }
160
155 title: i18n.tr("Contacts")161 title: i18n.tr("Contacts")
156162
157 flickable: null163 flickable: null
@@ -541,12 +547,6 @@
541 }547 }
542 }548 }
543549
544 function onNewContactSaved(contact) {
545 if (pageStack.columns > 1) {
546 showContact(contact);
547 }
548 }
549
550 Component {550 Component {
551 id: editorPageBottomEdge551 id: editorPageBottomEdge
552 ABContactEditorPage {552 ABContactEditorPage {
@@ -578,12 +578,7 @@
578 id: bottomEdge578 id: bottomEdge
579 objectName: "bottomEdge"579 objectName: "bottomEdge"
580580
581 anchors.fill: parent581 property var incubator
582 contentComponent: pageStack.columns == 1 ? editorPageBottomEdge : emptyContact
583 flickable: contactList
584 iconName: "contact-new"
585 enabled: !contactList.isInSelectionMode
586 backGroundEffectEnabled: pageStack.columns === 1
587582
588 // FIXME: this is a workaround for the lack of fully asynchronous loading583 // FIXME: this is a workaround for the lack of fully asynchronous loading
589 // of Pages in AdaptativePageLayout584 // of Pages in AdaptativePageLayout
@@ -600,7 +595,6 @@
600 }595 }
601 }596 }
602597
603 property var incubator
604 function incubateObject(component, properties, callback) {598 function incubateObject(component, properties, callback) {
605 if (component.status == Component.Ready) {599 if (component.status == Component.Ready) {
606 incubator = component.incubateObject(null,600 incubator = component.incubateObject(null,
@@ -624,6 +618,13 @@
624 showContactEditorPage);618 showContactEditorPage);
625 }619 }
626620
621 anchors.fill: parent
622 contentComponent: pageStack.columns == 1 ? editorPageBottomEdge : emptyContact
623 flickable: contactList
624 iconName: "contact-new"
625 enabled: !contactList.isInSelectionMode
626 backGroundEffectEnabled: pageStack.columns === 1
627
627 onOpenBegin: {628 onOpenBegin: {
628 contactList.prepareNewContact = true;629 contactList.prepareNewContact = true;
629 contactList.positionViewAtBeginning();630 contactList.positionViewAtBeginning();

Subscribers

People subscribed via source and target branches