Merge lp:~renatofilho/address-book-app/code-style-fix into lp:~fboucault/address-book-app/converged_bottom_edge

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 509
Proposed branch: lp:~renatofilho/address-book-app/code-style-fix
Merge into: lp:~fboucault/address-book-app/converged_bottom_edge
Diff against target: 65 lines (+14/-13)
1 file modified
src/imports/ABContactListPage.qml (+14/-13)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/code-style-fix
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+275530@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ABContactListPage.qml'
2--- src/imports/ABContactListPage.qml 2015-10-23 11:05:56 +0000
3+++ src/imports/ABContactListPage.qml 2015-10-23 12:41:25 +0000
4@@ -152,6 +152,12 @@
5 editorPage.contactSaved.connect(onNewContactSaved);
6 }
7
8+ function onNewContactSaved(contact) {
9+ if (pageStack.columns > 1) {
10+ showContact(contact);
11+ }
12+ }
13+
14 title: i18n.tr("Contacts")
15
16 flickable: null
17@@ -541,12 +547,6 @@
18 }
19 }
20
21- function onNewContactSaved(contact) {
22- if (pageStack.columns > 1) {
23- showContact(contact);
24- }
25- }
26-
27 Component {
28 id: editorPageBottomEdge
29 ABContactEditorPage {
30@@ -578,12 +578,7 @@
31 id: bottomEdge
32 objectName: "bottomEdge"
33
34- anchors.fill: parent
35- contentComponent: pageStack.columns == 1 ? editorPageBottomEdge : emptyContact
36- flickable: contactList
37- iconName: "contact-new"
38- enabled: !contactList.isInSelectionMode
39- backGroundEffectEnabled: pageStack.columns === 1
40+ property var incubator
41
42 // FIXME: this is a workaround for the lack of fully asynchronous loading
43 // of Pages in AdaptativePageLayout
44@@ -600,7 +595,6 @@
45 }
46 }
47
48- property var incubator
49 function incubateObject(component, properties, callback) {
50 if (component.status == Component.Ready) {
51 incubator = component.incubateObject(null,
52@@ -624,6 +618,13 @@
53 showContactEditorPage);
54 }
55
56+ anchors.fill: parent
57+ contentComponent: pageStack.columns == 1 ? editorPageBottomEdge : emptyContact
58+ flickable: contactList
59+ iconName: "contact-new"
60+ enabled: !contactList.isInSelectionMode
61+ backGroundEffectEnabled: pageStack.columns === 1
62+
63 onOpenBegin: {
64 contactList.prepareNewContact = true;
65 contactList.positionViewAtBeginning();

Subscribers

People subscribed via source and target branches