Ubuntu
ubuntu-advantage-tools package

Code review comment for ~renanrodrigo/ubuntu/+source/ubuntu-advantage-tools:upload-27.11.3-kinetic

  1. Git
  2. lp:~renanrodrigo/ubuntu/+source/ubuntu-advantage-tools
  3. upload-27.11.3-kinetic
  4. Merge into ubuntu/devel
Revision history for this message
Grant Orndorff (orndorffgrant) wrote :

Thank you racb and paride for the reviews!

As mentioned in my last comment there are some tweaks incoming. You can see a preview of what they might be here: https://github.com/canonical/ubuntu-advantage-client/pull/2293

They will at least include:
* modifying this output to only appear when using `apt` (and not `apt-get`)
* fixing https://github.com/canonical/ubuntu-advantage-client/issues/2294
* a change to the message itself, still not finalized

I've been told the message will be finalized by tomorrow, so hopefully by tomorrow I will have everything in place (SRU bug, updated MP) for another round of review and we can get this out by early next week.

I'll be sure to ping you both when it is ready.

Reply

« Back to merge proposal