Code review comment for lp:~reldan/nova/lp766282

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Thanks for the fixes.

> > I'm also not too keen on the removal of all the try/except's from the
> > _action_... methods. Why did you do this? You really shouldn't sneak in
> > changes that aren't directly related to the bug you are fixing. If you feel
> > differently, I would love to hear your thoughts.
>
> Just cleaning some old ugly code. If you really against it let me just revert
> this changes.

Like I said, I think we should really try and respect the scope defined in the bug report. Let's see if we can get somebody else to weigh in on this.

« Back to merge proposal