Merge lp:~rcj/cloud-init/lxd_group into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Robert C Jennings
Status: Merged
Merged at revision: 1179
Proposed branch: lp:~rcj/cloud-init/lxd_group
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
config/cloud.cfg (+1/-1)
To merge this branch: bzr merge lp:~rcj/cloud-init/lxd_group
Reviewer Review Type Date Requested Status
Ben Howard (community) Approve
cloud-init Commiters Pending
Review via email: mp+288587@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

From a user perspective, this is a good thing. +1

review: Approve
Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

From a user perspective, this is a good thing. +1

review: Approve
Revision history for this message
Scott Moser (smoser) wrote :

if the 'lxd' user does not exist then this will stack trace and not create the user.
I've changed the behavior now to create the group if it does not exist.

and then merged this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config/cloud.cfg'
--- config/cloud.cfg 2016-02-04 04:21:40 +0000
+++ config/cloud.cfg 2016-03-09 22:45:26 +0000
@@ -89,7 +89,7 @@
89 name: ubuntu89 name: ubuntu
90 lock_passwd: True90 lock_passwd: True
91 gecos: Ubuntu91 gecos: Ubuntu
92 groups: [adm, audio, cdrom, dialout, dip, floppy, netdev, plugdev, sudo, video]92 groups: [adm, audio, cdrom, dialout, dip, floppy, lxd, netdev, plugdev, sudo, video]
93 sudo: ["ALL=(ALL) NOPASSWD:ALL"]93 sudo: ["ALL=(ALL) NOPASSWD:ALL"]
94 shell: /bin/bash94 shell: /bin/bash
95 # Other config here will be given to the distro class and/or path classes95 # Other config here will be given to the distro class and/or path classes