Code review comment for lp:~rcart/ubuntu/natty/bittornado/fix-420387

Revision history for this message
Artur Rona (ari-tczew) wrote :

5) Package is in quilt 3.0 source format, so please change your patch filename to *.patch, not *.dpatch and update series file. Debian should update their files.

6) I would like to see following entry in debian/changelog:

  * debian/patches/32_use_hashlib_for_sha.patch:
    - Updated use of deprecated sha module to hashlib. (LP: #420387)
  * Removed old CVS dir so it can use .bzr dir for Bazaar.

7) What about forwarding this patch to Debian?

Thank you for your contribution!

review: Needs Fixing

« Back to merge proposal