Merge lp:~rblasch/subvertpy/svn1.6-cygwin into lp:~jelmer/subvertpy/trunk

Proposed by Ronald Blaschke
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 2418
Merged at revision: 2417
Proposed branch: lp:~rblasch/subvertpy/svn1.6-cygwin
Merge into: lp:~jelmer/subvertpy/trunk
Diff against target: 83 lines (+16/-4)
4 files modified
subvertpy/_ra.c (+4/-4)
subvertpy/tests/__init__.py (+4/-0)
subvertpy/tests/test_client.py (+4/-0)
subvertpy/tests/test_ra.py (+4/-0)
To merge this branch: bzr merge lp:~rblasch/subvertpy/svn1.6-cygwin
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+81596@code.launchpad.net

Description of the change

Some small changes for Cygwin using Subversion 1.6.

* Makes the test suite pass.
* Add Windows SVN auth. windows-cryptoapi password store is used by default
  on Cygwin.

$ make check
python setup.py build_ext --inplace
running build_ext
PYTHONPATH=.: python -m unittest2.__main__ subvertpy.tests.test_suite
........................................................................................................................................................................
----------------------------------------------------------------------
Ran 168 tests in 16.844s

OK

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'subvertpy/_ra.c'
--- subvertpy/_ra.c 2011-09-23 23:49:59 +0000
+++ subvertpy/_ra.c 2011-11-08 15:34:57 +0000
@@ -3047,7 +3047,7 @@
3047 return ret;3047 return ret;
3048}3048}
30493049
3050#if defined(WIN32)3050#if defined(WIN32) || defined(__CYGWIN__)
3051static PyObject *get_windows_simple_provider(PyObject* self)3051static PyObject *get_windows_simple_provider(PyObject* self)
3052{3052{
3053 AuthProviderObject *auth = PyObject_New(AuthProviderObject, &AuthProvider_Type);3053 AuthProviderObject *auth = PyObject_New(AuthProviderObject, &AuthProvider_Type);
@@ -3153,7 +3153,7 @@
3153 return NULL;3153 return NULL;
3154 }3154 }
31553155
3156#if defined(WIN32)3156#if defined(WIN32) || defined(__CYGWIN__)
3157 provider = get_windows_simple_provider(self);3157 provider = get_windows_simple_provider(self);
3158 if (provider == NULL)3158 if (provider == NULL)
3159 return NULL;3159 return NULL;
@@ -3167,7 +3167,7 @@
3167 PyList_Append(pylist, provider);3167 PyList_Append(pylist, provider);
3168 Py_DECREF(provider);3168 Py_DECREF(provider);
3169#endif /* 1.5 */3169#endif /* 1.5 */
3170#endif /* WIN32 */3170#endif /* WIN32 || __CYGWIN__ */
31713171
3172#if defined(SVN_KEYCHAIN_PROVIDER_AVAILABLE)3172#if defined(SVN_KEYCHAIN_PROVIDER_AVAILABLE)
3173 provider = get_keychain_simple_provider(self);3173 provider = get_keychain_simple_provider(self);
@@ -3193,7 +3193,7 @@
3193 { "get_ssl_client_cert_file_provider", (PyCFunction)get_ssl_client_cert_file_provider, METH_NOARGS, NULL },3193 { "get_ssl_client_cert_file_provider", (PyCFunction)get_ssl_client_cert_file_provider, METH_NOARGS, NULL },
3194 { "get_ssl_server_trust_file_provider", (PyCFunction)get_ssl_server_trust_file_provider, METH_NOARGS, NULL },3194 { "get_ssl_server_trust_file_provider", (PyCFunction)get_ssl_server_trust_file_provider, METH_NOARGS, NULL },
3195 { "get_simple_provider", (PyCFunction)get_simple_provider, METH_VARARGS, NULL },3195 { "get_simple_provider", (PyCFunction)get_simple_provider, METH_VARARGS, NULL },
3196#if defined(WIN32)3196#if defined(WIN32) || defined(__CYGWIN__)
3197 { "get_windows_simple_provider", (PyCFunction)get_windows_simple_provider, METH_NOARGS, NULL },3197 { "get_windows_simple_provider", (PyCFunction)get_windows_simple_provider, METH_NOARGS, NULL },
3198#if ONLY_SINCE_SVN(1, 5)3198#if ONLY_SINCE_SVN(1, 5)
3199 { "get_windows_ssl_server_trust_provider", (PyCFunction)get_windows_ssl_server_trust_provider, METH_NOARGS, NULL },3199 { "get_windows_ssl_server_trust_provider", (PyCFunction)get_windows_ssl_server_trust_provider, METH_NOARGS, NULL },
32003200
=== modified file 'subvertpy/tests/__init__.py'
--- subvertpy/tests/__init__.py 2011-08-26 02:15:09 +0000
+++ subvertpy/tests/__init__.py 2011-11-08 15:34:57 +0000
@@ -202,6 +202,10 @@
202 super(SubversionTestCase, self).setUp()202 super(SubversionTestCase, self).setUp()
203 self._init_client()203 self._init_client()
204204
205 def tearDown(self):
206 del self.client_ctx
207 super(SubversionTestCase, self).tearDown()
208
205 def log_message_func(self, items):209 def log_message_func(self, items):
206 return self.next_message210 return self.next_message
207211
208212
=== modified file 'subvertpy/tests/test_client.py'
--- subvertpy/tests/test_client.py 2011-09-19 21:42:24 +0000
+++ subvertpy/tests/test_client.py 2011-11-08 15:34:57 +0000
@@ -49,6 +49,10 @@
49 self.repos_url = self.make_client("d", "dc")49 self.repos_url = self.make_client("d", "dc")
50 self.client = client.Client(auth=ra.Auth([ra.get_username_provider()]))50 self.client = client.Client(auth=ra.Auth([ra.get_username_provider()]))
5151
52 def tearDown(self):
53 del self.client
54 super(TestClient, self).tearDown()
55
52 def test_add(self):56 def test_add(self):
53 self.build_tree({"dc/foo": None})57 self.build_tree({"dc/foo": None})
54 self.client.add("dc/foo")58 self.client.add("dc/foo")
5559
=== modified file 'subvertpy/tests/test_ra.py'
--- subvertpy/tests/test_ra.py 2011-08-26 02:15:09 +0000
+++ subvertpy/tests/test_ra.py 2011-11-08 15:34:57 +0000
@@ -53,6 +53,10 @@
53 self.ra = ra.RemoteAccess(self.repos_url,53 self.ra = ra.RemoteAccess(self.repos_url,
54 auth=ra.Auth([ra.get_username_provider()]))54 auth=ra.Auth([ra.get_username_provider()]))
5555
56 def tearDown(self):
57 del self.ra
58 super(TestRemoteAccess, self).tearDown()
59
56 def commit_editor(self):60 def commit_editor(self):
57 return self.get_commit_editor(self.repos_url)61 return self.get_commit_editor(self.repos_url)
5862

Subscribers

People subscribed via source and target branches