Code review comment for lp:~rbanffy/maas/1510210-cant-delete-user

Revision history for this message
Ricardo Bánffy (rbanffy) wrote :

> Looks generally good, but I think your to strict on the checking. We should
> not prevent the user from being deleted if they have ssh keys or ssl keys.
> Those are directly related to the user, we can just delete those when the user
> is deleted. Actually you can set those to CASCADE and they will be deleted for
> you, I believe.

Yes. That's an option. Just need to remove the extra checks and change the tests to reflect the new behavior.

« Back to merge proposal