Code review comment for lp:~rbalint/update-notifier/motd-stale-pkglist

Revision history for this message
Balint Reczey (rbalint) wrote :

> > I chose to hardcode one week to keep the gettext string very simple and
> > IMO it is a reasonable time after which staleness should be reported.
>
> Fair enough.
>
> > snap info microk8s
> > The information about available updates is more than a week old.
>
> Has Launchpad muddled the display here, or is there really no blank line
> before the new text? It would be weird if there was often a blank line
> *within* the previous text (for example, within the Kubernetes stuff here),
> but not after it.

I added no newline before the text because there is an extra at the end in /var/lib/update-notifier/updates-available and I did not want to remove that now.
I see that it is ugly when /var/lib/update-notifier/updates-available is empty, thus I'm adding it now and maybe the extra line can be removed from updates-available later.

>
> > The information about available updates is more than a week old.
>
> This reads a bit mysterious. What kind of information? Their size? Their
> authors? Simpler just to say “It’s been more than a week since the last check
> for updates.”
>
> Similarly, “To download information about new updates run:” could just be “To
> check now:”.

Good points.
IMO "It’s been" is a bit informal though, how about:

The list of available updates is more than a week old.
To check for new updates run: sudo apt update

« Back to merge proposal