Merge ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870930 into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal

Proposed by Balint Reczey
Status: Merged
Merge reported by: Dan Streetman
Merged at revision: 98814fc1bf79188d852c67e76e06cd26c0e3d501
Proposed branch: ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870930
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal
Diff against target: 42 lines (+25/-0)
2 files modified
debian/patches/series (+1/-0)
debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch (+24/-0)
Reviewer Review Type Date Requested Status
Dan Streetman Approve
Review via email: mp+382732@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dan Streetman (ddstreet) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/patches/series b/debian/patches/series
index 1eea8ff..da98bb1 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -11,6 +11,7 @@ units-drop-systemd-remount-fs.service-dependency-from-mor.patch
11units-make-sure-systemd-pstore-stops-at-shutdown.patch11units-make-sure-systemd-pstore-stops-at-shutdown.patch
12network-do-not-re-attach-sd-event-object.patch12network-do-not-re-attach-sd-event-object.patch
13network-attach-sd-event-in-link_load-when-creating-link-d.patch13network-attach-sd-event-in-link_load-when-creating-link-d.patch
14shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
14debian/Use-Debian-specific-config-files.patch15debian/Use-Debian-specific-config-files.patch
15debian/Bring-tmpfiles.d-tmp.conf-in-line-with-Debian-defaul.patch16debian/Bring-tmpfiles.d-tmp.conf-in-line-with-Debian-defaul.patch
16debian/Make-run-lock-tmpfs-an-API-fs.patch17debian/Make-run-lock-tmpfs-an-API-fs.patch
diff --git a/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch b/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
17new file mode 10064418new file mode 100644
index 0000000..af8d7ba
--- /dev/null
+++ b/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
@@ -0,0 +1,24 @@
1From: Balint Reczey <balint.reczey@canonical.com>
2Date: Wed, 22 Apr 2020 09:51:53 +0200
3Subject: shared: Don't try calling NULL callback in bus_wait_for_units_clear
4
5BugLink: https://bugs.launchpad.net/bugs/1870930
6(cherry picked from commit 16d14b4474243f6e06db579582c1fb1bcd13131b)
7---
8 src/shared/bus-wait-for-units.c | 3 ++-
9 1 file changed, 2 insertions(+), 1 deletion(-)
10
11diff --git a/src/shared/bus-wait-for-units.c b/src/shared/bus-wait-for-units.c
12index 78b2a60..ed0442f 100644
13--- a/src/shared/bus-wait-for-units.c
14+++ b/src/shared/bus-wait-for-units.c
15@@ -91,7 +91,8 @@ static void bus_wait_for_units_clear(BusWaitForUnits *d) {
16 while ((item = hashmap_first(d->items))) {
17 d->current = item;
18
19- item->unit_callback(d, item->bus_path, false, item->userdata);
20+ if (item->unit_callback)
21+ item->unit_callback(d, item->bus_path, false, item->userdata);
22 wait_for_item_free(item);
23 }
24

Subscribers

People subscribed via source and target branches