Merge ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870930 into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal

Proposed by Balint Reczey
Status: Merged
Merge reported by: Dan Streetman
Merged at revision: 98814fc1bf79188d852c67e76e06cd26c0e3d501
Proposed branch: ~rbalint/ubuntu/+source/systemd:ubuntu-focal-lp1870930
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal
Diff against target: 42 lines (+25/-0)
2 files modified
debian/patches/series (+1/-0)
debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch (+24/-0)
Reviewer Review Type Date Requested Status
Dan Streetman Approve
Review via email: mp+382732@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dan Streetman (ddstreet) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/patches/series b/debian/patches/series
2index 1eea8ff..da98bb1 100644
3--- a/debian/patches/series
4+++ b/debian/patches/series
5@@ -11,6 +11,7 @@ units-drop-systemd-remount-fs.service-dependency-from-mor.patch
6 units-make-sure-systemd-pstore-stops-at-shutdown.patch
7 network-do-not-re-attach-sd-event-object.patch
8 network-attach-sd-event-in-link_load-when-creating-link-d.patch
9+shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
10 debian/Use-Debian-specific-config-files.patch
11 debian/Bring-tmpfiles.d-tmp.conf-in-line-with-Debian-defaul.patch
12 debian/Make-run-lock-tmpfs-an-API-fs.patch
13diff --git a/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch b/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
14new file mode 100644
15index 0000000..af8d7ba
16--- /dev/null
17+++ b/debian/patches/shared-Don-t-try-calling-NULL-callback-in-bus_wait_for_un.patch
18@@ -0,0 +1,24 @@
19+From: Balint Reczey <balint.reczey@canonical.com>
20+Date: Wed, 22 Apr 2020 09:51:53 +0200
21+Subject: shared: Don't try calling NULL callback in bus_wait_for_units_clear
22+
23+BugLink: https://bugs.launchpad.net/bugs/1870930
24+(cherry picked from commit 16d14b4474243f6e06db579582c1fb1bcd13131b)
25+---
26+ src/shared/bus-wait-for-units.c | 3 ++-
27+ 1 file changed, 2 insertions(+), 1 deletion(-)
28+
29+diff --git a/src/shared/bus-wait-for-units.c b/src/shared/bus-wait-for-units.c
30+index 78b2a60..ed0442f 100644
31+--- a/src/shared/bus-wait-for-units.c
32++++ b/src/shared/bus-wait-for-units.c
33+@@ -91,7 +91,8 @@ static void bus_wait_for_units_clear(BusWaitForUnits *d) {
34+ while ((item = hashmap_first(d->items))) {
35+ d->current = item;
36+
37+- item->unit_callback(d, item->bus_path, false, item->userdata);
38++ if (item->unit_callback)
39++ item->unit_callback(d, item->bus_path, false, item->userdata);
40+ wait_for_item_free(item);
41+ }
42+

Subscribers

People subscribed via source and target branches