Code review comment for lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader-screen

> On Tue, May 02, 2017 at 08:33:33AM -0000, Balint Reczey wrote:
> > I would not like screen logging by default. There can be sensitive
> information in the terminal from remote systems for example.
>
> I'm not sure I understand this point, the screenrc file in the
> dist-upgrader tarball is only used when the distribution upgrade process
> calls screen and it logged whenever it called screen anyway so whether
> we try and use -L or set the log options in the screenrc file the
> results are the same.

I thought you were referring to screen package's screenrc not the one we use here.
I think using the screenrc in the downloaded tarball is the best option indeed and
even if screen gets fixed in Zesty it is cleaner.

I have updated the patch to use screenrc and dropped the autopkgtest because it is
not really worth it to run it only for this small change.

>
> > I have updated the patch to use screenlog.0, but there seems to be an even
> better option, updating screen in Zesty :-):
>
> Fixing screen does seem like the best idea though.
>
> --
> Brian Murray