Code review comment for lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader-screen

Revision history for this message
Balint Reczey (rbalint) wrote :

I would not like screen logging by default. There can be sensitive information in the terminal from remote systems for example.

I have updated the patch to use screenlog.0, but there seems to be an even better option, updating screen in Zesty :-):

I'm glad to announce that the new version of GNU Screen (4.5.1) has been released today!

https://savannah.gnu.org/forum/forum.php?forum_id=8807 :

 ...
 4.5.1 is a bugfix/security release.
 We fixed few crashes and, of course, problem with privilege escalation.
 We also changed behavior of '-L' option: now you can set new logfile name using '-Logfile' option and '-L' just tells screen to turn on logging.
 ...

« Back to merge proposal