Code review comment for lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader-screen

Revision history for this message
Brian Murray (brian-murray) wrote :

Okay, I was just trying to find a way that would reduce the amount of changes necessary to resolve the issue. Given that we are distributing and using our own screenrc file I thought we might get it to work by modifying it. I added the following lines to screenrc:

deflog on
log on

I also removed the passing of the -L switch to screen and that seemed to work i.e. /var/log/dist-upgrade/screenlog.0 was written to. What do you think about that instead?

It's also worth noting that the apport package hooks collects the screenlog and expects the log file name to be screenlog.0 so we should keep that log file name the same.

« Back to merge proposal