Merge ~rbalint/autopkgtest-cloud:more-retry-strings into autopkgtest-cloud:master

[Balint Reczey]

[Iain Lane (laney)]

I can understand the PPA timeout, but what is the other one about?

[Iain Lane (laney)]

review: Needs Information

[Balint Reczey (rbalint)]

@laney I've opened a bug for it, please see it in the commit message.

fb22bd7... by Balint Reczey on 2020-11-16

worker: Retry on E: Failed to fetch http://ftpmaster.internal/

[Iain Lane (laney)]

Semi-approve. I've not taken 93871e3, because I'm not sure you've hit the right message there.

If you look at the code for autopkgtest itself, you can see that apt-mark is something that the controller asks the testbed to execute. It could be any of the other commands run with check_exec() that fail like this, not just apt-mark. If we look like this I think we'll end up adding more and more messages for all the different things that area check_exec()ed.

Could you maybe re-submit another merge proposal targetting the other half of the error please? I'm not sure exactly what flakes out there either (the cloud itself?), would be good to investigate that too.

review: Approve

diff --git a/worker/worker b/worker/worker
index f0f304b..145e19b 100755
--- a/worker/worker
+++ b/worker/worker
@@ -58,6 +58,9 @@ FAIL_STRINGS = ['Kernel panic - not syncing:',
                 'Faulting instruction address:',
                 'Call Trace:']
 TEMPORARY_TEST_FAIL_STRINGS = ['Could not connect to ftpmaster.internal:80',
+                               'Cannot initiate the connection to ppa.launchpad.net:80',
+                               'ERROR: "apt-mark manual -qq ',
+                               'E: Failed to fetch http://ftpmaster.internal/'
                                'Temporary failure resolving',
                                'Temporary failure in name resolution',
                                'Unable to connect to ftpmaster.internal:http:',