Code review comment for lp:~raxnetworking/nova/melange

Revision history for this message
Vish Ishaya (vishvananda) wrote :

This is looking good guys. First impression is that the code is pretty clean and well laid out. Quick nits in my first glance at the code:

Not sure about the changes to bzrignore. Why remove the ignores for logs and sqlite dbs?

3320 +required_dbs=['mysql','postgres','sqllite']
extra l in sqlite.

Are there some tests as well? I see reference to melage/tests/unit in a couple places, but no actual code

review: Needs Information

« Back to merge proposal