lp:~raoul-snyman/openlp/bug-1742910

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:openlp at revision 2808

Tim Bentley: Approve on 2018-01-13

Diff: 755 lines (+333/-194)

10 files modified

openlp/core/app.py (+1/-1)
openlp/core/common/path.py (+2/-2)
openlp/core/threading.py (+14/-10)
openlp/core/ui/mainwindow.py (+3/-4)
tests/functional/openlp_core/api/http/test_error.py (+37/-35)
tests/functional/openlp_core/api/test_deploy.py (+94/-15)
tests/functional/openlp_core/common/test_path.py (+14/-1)
tests/functional/openlp_core/lib/test_path.py (+0/-87)
tests/functional/openlp_core/lib/test_ui.py (+55/-28)
tests/functional/openlp_core/test_threading.py (+113/-11)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1742910: first time wizard crashes

Critical

Fix Committed

Link a bug report

Related blueprints

2812. By Raoul Snyman on 2018-01-13

Go back to the way I was doing it originally. Much more succint.

2811. By Raoul Snyman on 2018-01-13

Change is_thread_finished() to return True if a thread is missing

2810. By Raoul Snyman on 2018-01-13

Removed a duplicate test file, fixed up some tests, added some more tests

2809. By Raoul Snyman on 2018-01-12

Add some more tests for openlp.core.api.deploy

2808. By Raoul Snyman on 2018-01-12

Fix bug #1742910

2807. By Raoul Snyman on 2018-01-07

Major overhaul of how threading in OpenLP works. Rather than messing around with threads yourself, you create a worker object descended from ThreadWorker, implement start() (and stop() if it's a long-running thread), and run it using run_thread().

Changes related to thread API:

- WebSocket was refactored (mostly into the worker)
- HttpServer was refactored a bit
- CheckMediaWorker was refactored a bit
- Version check refactored
- SongSelect search refactored
- New _wait_for_threads() method...

2806. By Ken Roberts on 2018-01-03

--------------------------------------------------------------------------------
lp:~alisonken1/openlp/pjlink2-n (revision 2806)
https://ci.openlp.io/job/Branch-01-Pull/2409/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2310/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/105/ [SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/29/ [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-ma...

2805. By Simon Hanna on 2018-01-02

Fixed the version checking to be more robust

* Strip the response so empty responses that contain whitespace are in fact empty
* Change http to https to result in one less query
* Add test for responses containing white space
* Add .cache to bzrignore (generated by pytest when tests fail)

2804. By Tim Bentley on 2018-01-01

Update the year to 2018
Add some missing copyright files
Reorder and fix the imports for all files.
Fix a timing issue with the mac build which makes it fail all the time.

lp:~trb143/openlp/textcleanups (revision 2812)
https://ci.openlp.io/job/Branch-01-Pull/2406/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2307/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/102/ [SUCCESS]
https://ci.openlp.io/job/Branch-03...

2803. By Phill on 2017-12-24

Move song test resources

lp:~phill-ridout/openlp/moar_test_cleanups (revision 2809)
https://ci.openlp.io/job/Branch-01-Pull/2390/ [WAITING]
[RUNNING]
[SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2291/ [WAITING]
[RUNNING]
[SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/86/ [WAITING]
[SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/11/ [WAITING]
[SUCCESS]
https://ci.openlp.io/job/Bra...