Merge lp:~raoul-snyman/openlp/bug-1216785-2.0 into lp:openlp/2.0

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2167
Proposed branch: lp:~raoul-snyman/openlp/bug-1216785-2.0
Merge into: lp:openlp/2.0
Diff against target: 24 lines (+2/-1)
2 files modified
openlp/core/ui/servicemanager.py (+1/-1)
openlp/core/ui/servicenoteform.py (+1/-0)
To merge this branch: bzr merge lp:~raoul-snyman/openlp/bug-1216785-2.0
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+182193@code.launchpad.net

Description of the change

Fix bug #1216785 by casting to unicode before adding to the service.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/core/ui/servicemanager.py'
--- openlp/core/ui/servicemanager.py 2013-06-30 12:14:30 +0000
+++ openlp/core/ui/servicemanager.py 2013-08-26 19:28:22 +0000
@@ -796,7 +796,7 @@
796 self.serviceItems[item][u'service_item'].notes)796 self.serviceItems[item][u'service_item'].notes)
797 if self.serviceNoteForm.exec_():797 if self.serviceNoteForm.exec_():
798 self.serviceItems[item][u'service_item'].notes = \798 self.serviceItems[item][u'service_item'].notes = \
799 self.serviceNoteForm.textEdit.toPlainText()799 unicode(self.serviceNoteForm.textEdit.toPlainText())
800 self.repaintServiceList(item, -1)800 self.repaintServiceList(item, -1)
801 self.setModified()801 self.setModified()
802802
803803
=== modified file 'openlp/core/ui/servicenoteform.py'
--- openlp/core/ui/servicenoteform.py 2012-12-30 19:41:24 +0000
+++ openlp/core/ui/servicenoteform.py 2013-08-26 19:28:22 +0000
@@ -32,6 +32,7 @@
32from openlp.core.lib import translate, SpellTextEdit32from openlp.core.lib import translate, SpellTextEdit
33from openlp.core.lib.ui import create_button_box33from openlp.core.lib.ui import create_button_box
3434
35
35class ServiceNoteForm(QtGui.QDialog):36class ServiceNoteForm(QtGui.QDialog):
36 """37 """
37 This is the form that is used to edit the verses of the song.38 This is the form that is used to edit the verses of the song.

Subscribers

People subscribed via source and target branches