I can't comment on much of the code, not familiar with sqlalchemy, but while I'm here...
Niggles: 420 + osis = codecs.open(osisfile_record, u'r', details['encoding']) Is there a reason 'encoding' shouldn't be unicode?
1088 +mapper(ONTestament, testament_table, 1089 + properties={'books': relation(Book, backref='testament')}) 1090 +mapper(Book, book_table, 1091 + properties={'verses': relation(Verse, backref='book')})
More unicode strings?
« Back to merge proposal
I can't comment on much of the code, not familiar with sqlalchemy, but while I'm here...
Niggles: open(osisfile_ record, u'r', details[ 'encoding' ])
420 + osis = codecs.
Is there a reason 'encoding' shouldn't be unicode?
1088 +mapper( ONTestament, testament_table, {'books' : relation(Book, backref= 'testament' )}) {'verses' : relation(Verse, backref='book')})
1089 + properties=
1090 +mapper(Book, book_table,
1091 + properties=
More unicode strings?