Code review comment for lp:~raoul-snyman/openlp/biblefixes

Revision history for this message
Martin Thompson (mjthompson) wrote :

I can't comment on much of the code, not familiar with sqlalchemy, but while I'm here...

Niggles:
420 + osis = codecs.open(osisfile_record, u'r', details['encoding'])
Is there a reason 'encoding' shouldn't be unicode?

1088 +mapper(ONTestament, testament_table,
1089 + properties={'books': relation(Book, backref='testament')})
1090 +mapper(Book, book_table,
1091 + properties={'verses': relation(Verse, backref='book')})

More unicode strings?

review: Approve

« Back to merge proposal