Mir

Code review comment for lp:~raof/mir/use-dma-buf

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

22 === added file 'include/shared/mir/frontend/client_constants.h
...
52 +/// mir::client::ClientBufferDepository and mir::frontend::ClientBufferTracker need to use the same value
53 +unsigned int const client_buffer_cache_size = 3;

There's obviously conflicting forces to resolve in deciding where to put this, but I don't think namespace mir is the right answer. Especially when the file suggests namespace mir::frontend.

At the moment I'm struggling to understand why the server needs to be *compiled* with the size of a client-side cache - but maybe I'll grok that later. In any case, something here needs fixing.

review: Needs Fixing

« Back to merge proposal