Mir

Code review comment for lp:~raof/mir/udevify-eventhub

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(3) deploy-and-test.sh: There are some duplicated very long lines there. They should be unduplicated into $VARIABLES and line length more controlled with \ continuation.

(4) Please avoid hardcoded paths: /home/phablet/mir/usr
Any developer with multiple branches on the go will have their own install/path scheme for droids.

(5) I think I failed to mention that I don't use "adb push" so any script has to avoid transferring files for me. I use "rsync" (and "start ssh" on the device) as it only copies what's changed between rebuilds. If you avoided doing the deployment/push in your script then it would also resolve (4). Simply populating the local build/{bin,lib} is enough, then let the developer copy the files in their own way.

review: Needs Fixing

« Back to merge proposal