Mir

Code review comment for lp:~raof/mir/udevify-eventhub

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

When you swap 1473 for
#include "src/server/report/null_report_factory.h"

the lines 1516, 1534 and 1561 could be written as:
+ 1516 auto hub = new android::EventHub{mir::report::null_input_report()};

and you could remove the lines of 1481 to 1504

but not really a blocker.

review: Approve

« Back to merge proposal