Mir

Code review comment for lp:~raof/mir/udevify-eventhub

  1. udevify-eventhub
  2. Merge into development-branch
Revision history for this message
Kevin DuBois (kdub) wrote :

looks okay overall.

155 - bool usingSuspendBlockIoctl = !ioctl(fd, EVIOCSSUSPENDBLOCK, 1);

Makes me a bit leery, I think some of the android devices still use wakelocks/earlysuspend. If it was removed just to make valgrind less chattery, I'd rather leave the line in.

review: Needs Information

« Back to merge proposal