> Why do you deal with environment in 918 and the following by just using
> options.parse_environment(.."MIR_SERVER_"). Additionally the priority between
> environment value and command line option is in the current MP:
nm, forgot about mir::options behavior towards unknown environment variables..
additional nits:
677, 749 for (
With this MP we could rename the graphics_platform_path to just platform_path, and the define MIR_SERVER_PLATFORM_VERSION to MIR_SERVER_GRAPHICS_PLATFORM_VERSION.
> Why do you deal with environment in 918 and the following by just using parse_environme nt(.."MIR_ SERVER_ "). Additionally the priority between
> options.
> environment value and command line option is in the current MP:
nm, forgot about mir::options behavior towards unknown environment variables..
additional nits:
677, 749 for (
With this MP we could rename the graphics_ platform_ path to just platform_path, and the define MIR_SERVER_ PLATFORM_ VERSION to MIR_SERVER_ GRAPHICS_ PLATFORM_ VERSION.
So with that I am done reviewing.