Since you already used 'graphics' in the ABI and since we are slowly moving towards an input platform library:
suggestion: l308: platform_library -> platfom_graphics_library
l772: catch by reference
l:1671 : why those changes? I thought this only changes the server side part?
l:1746: It seems that the contents of input_recordings/ are not in use anymore, you could also just drop it.
less of a needs fixing: Thinking about input platform: mir::ModuleProperties instead of mir::graphics::ModuleProperties or do you expect graphics related information there?
Since you already used 'graphics' in the ABI and since we are slowly moving towards an input platform library: graphics_ library
suggestion: l308: platform_library -> platfom_
l772: catch by reference
l:1671 : why those changes? I thought this only changes the server side part?
l:1746: It seems that the contents of input_recordings/ are not in use anymore, you could also just drop it.
less of a needs fixing: Thinking about input platform: mir::ModuleProp erties instead of mir::graphics: :ModuleProperti es or do you expect graphics related information there?