Mir

Code review comment for lp:~raof/mir/provide-event-fd

Revision history for this message
Robert Carr (robertcarr) wrote :

2 small needs fixing:

The 1 second timeouts are going to fail in ARMHF valgrind.

1499 + GError* err = nullptr;

Here and at 1511 please use g_error_free (I know a leak is unlikely to matter here but its worth using the API correctly I think)

review: Needs Fixing

« Back to merge proposal