Code review comment for lp:~raof/mir/provide-event-fd

I really like the way this turned out :)

A few nits:

+TEST_F(ClientLibrary, manual_dispatch_handles_callbacks_in_parent_thread)

I think its worth refactoring this and the following test. If you merged the TestData and test up to SurfaceCreation in to a fixture it would be possible to then split the sections of the test without duplicating code. Then the next test could not have to deal with surface states and umockdev recordings in the same test.

1888 and elsewhere + auto connection = std::make_shared<MirConnection>(conf);

You can keep connection in the fixture and then inherit from the fixture with
MirConnectionAutomaticDispatchTest and MirConnectionManualDispatchTest