Mir

Code review comment for lp:~raof/mir/provide-event-fd

Revision history for this message
Kevin DuBois (kdub) wrote :

int mir_connection_get_fd(MirConnection* connection);
It seems more important what the fd is for, so I'd rather the fn say something about what the fd does... maybe:
int mir_connection_event_dispatch_fd(MirConnection* connection)

201 + thread_local static bool running;
Nothing wrong here, but we still haven't properly sorted out TLS with hybris. We'd probably be a bit more robust if we still avoid using TLS.

704 + if (pipe2(pipefds, O_NONBLOCK) < 0)
O_CLOEXEC?

review: Needs Fixing

« Back to merge proposal