Mir

Code review comment for lp:~raof/mir/probe-client-drivers

  1. probe-client-drivers
  2. Merge into development-branch
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Needs information:

Has this been tested under chroot/sbuild? (We don't wanna have last minute packaging issues during release.)

Nits/Comments:
719 + // TODO: Actually check what platform we're using, rather than blindly

Perhaps MirPlatformPackage should include a "platform signature". Something like "MESA", "ANDR", "STUB".
-----------------------
android.so, mesa.so, dummy.so are too generic. client-platform-{android|mesa|dummy}.so perhaps?

review: Needs Information

« Back to merge proposal