Mir

Code review comment for lp:~raof/mir/privatise-all-the-things

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> [ RUN ] SurfaceLoop.all_created_buffers_are_destroyed
> Build timed out (after 60 minutes). Marking the build as failed.

Sometimes tests hang. Sometimes CI is this slow. Who knows?!

~~~~

1204 +std::shared_ptr<mcl::ProbingClientPlatformFactory> the_platform_prober;

Having recently tracked down several problems caused by namespace scoped objects with state I'm concerned that this may be fragile.

~~~~

Triggering rebuild to see if it it gets through CI - will come back for a closer look later.

review: Abstain

« Back to merge proposal